Add visitor for handling views of type BitDecomposableMatrixVisitor t…

…o class IQuantization.
mrapp-ke · Oct 2, 2024 · 457e7db · 457e7db
1 parent a1c2c5c
commit 457e7db
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 5 deletions.
diff --git a/cpp/subprojects/boosting/include/mlrl/boosting/statistics/quantization.hpp b/cpp/subprojects/boosting/include/mlrl/boosting/statistics/quantization.hpp
@@ -3,6 +3,7 @@
  */
 #pragma once
 
+#include "mlrl/boosting/data/view_statistic_decomposable_bit.hpp"
 #include "mlrl/boosting/data/view_statistic_non_decomposable_dense.hpp"
 #include "mlrl/common/data/tuple.hpp"
 #include "mlrl/common/data/view_matrix_c_contiguous.hpp"
@@ -43,6 +44,13 @@ namespace boosting {
             typedef std::function<void(std::unique_ptr<IQuantizationMatrix<SparseSetView<Tuple<float64>>>>&)>
               SparseDecomposableMatrixVisitor;
 
+            /**
+             * A visitor function for handling quantization matrices that are backed by a view of the type
+             * `BitDecomposableStatisticView`.
+             */
+            typedef std::function<void(std::unique_ptr<IQuantizationMatrix<BitDecomposableStatisticView>>&)>
+              BitDecomposableMatrixVisitor;
+
             /**
              * A visitor function for handling quantization matrices that are backed by a view of the type
              * `DenseNonDecomposableStatisticView`.
@@ -57,6 +65,9 @@ namespace boosting {
              * @param denseDecomposableMatrixVisitor    An optional visitor function for handling quantization matrices
              *                                          that are backed by a view of the type
              *                                          `CContiguousView<Tuple<float64>>`
+             * @param bitDecomposableMatrixVisitor      An optional visitor function for handling quantization matrices
+             *                                          that are backed by a view of the type
+             *                                          `BitDecomposableStatisticView`
              * @param sparseDecomposableMatrixVisitor   An optional visitor function for handling quantization matrices
              *                                          that are backed by a view of the type
              *                                          `SparseSetView<Tuple<float64>>`
@@ -66,6 +77,7 @@ namespace boosting {
              */
             virtual void visitQuantizationMatrix(
               std::optional<DenseDecomposableMatrixVisitor> denseDecomposableMatrixVisitor,
+              std::optional<BitDecomposableMatrixVisitor> bitDecomposableMatrixVisitor,
               std::optional<SparseDecomposableMatrixVisitor> sparseDecomposableMatrixVisitor,
               std::optional<DenseNonDecomposableMatrixVisitor> denseNonDecomposableMatrixVisitor) = 0;
     };

diff --git a/cpp/subprojects/boosting/src/mlrl/boosting/statistics/quantization_no.cpp b/cpp/subprojects/boosting/src/mlrl/boosting/statistics/quantization_no.cpp
@@ -15,6 +15,7 @@ namespace boosting {
 
             void visitQuantizationMatrix(
               std::optional<IQuantization::DenseDecomposableMatrixVisitor> denseDecomposableMatrixVisitor,
+              std::optional<BitDecomposableMatrixVisitor> bitDecomposableMatrixVisitor,
               std::optional<IQuantization::SparseDecomposableMatrixVisitor> sparseDecomposableMatrixVisitor,
               std::optional<IQuantization::DenseNonDecomposableMatrixVisitor> denseNonDecomposableMatrixVisitor)
               override {
@@ -37,6 +38,7 @@ namespace boosting {
 
             void visitQuantizationMatrix(
               std::optional<IQuantization::DenseDecomposableMatrixVisitor> denseDecomposableMatrixVisitor,
+              std::optional<BitDecomposableMatrixVisitor> bitDecomposableMatrixVisitor,
               std::optional<IQuantization::SparseDecomposableMatrixVisitor> sparseDecomposableMatrixVisitor,
               std::optional<IQuantization::DenseNonDecomposableMatrixVisitor> denseNonDecomposableMatrixVisitor)
               override {
@@ -59,6 +61,7 @@ namespace boosting {
 
             void visitQuantizationMatrix(
               std::optional<IQuantization::DenseDecomposableMatrixVisitor> denseDecomposableMatrixVisitor,
+              std::optional<BitDecomposableMatrixVisitor> bitDecomposableMatrixVisitor,
               std::optional<IQuantization::SparseDecomposableMatrixVisitor> sparseDecomposableMatrixVisitor,
               std::optional<IQuantization::DenseNonDecomposableMatrixVisitor> denseNonDecomposableMatrixVisitor)
               override {

diff --git a/cpp/subprojects/boosting/src/mlrl/boosting/statistics/quantization_stochastic.cpp b/cpp/subprojects/boosting/src/mlrl/boosting/statistics/quantization_stochastic.cpp
@@ -19,10 +19,13 @@ namespace boosting {
 
             void visitQuantizationMatrix(
               std::optional<IQuantization::DenseDecomposableMatrixVisitor> denseDecomposableMatrixVisitor,
+              std::optional<BitDecomposableMatrixVisitor> bitDecomposableMatrixVisitor,
               std::optional<IQuantization::SparseDecomposableMatrixVisitor> sparseDecomposableMatrixVisitor,
               std::optional<IQuantization::DenseNonDecomposableMatrixVisitor> denseNonDecomposableMatrixVisitor)
               override {
-                // TODO Implement
+                if (bitDecomposableMatrixVisitor) {
+                    (*bitDecomposableMatrixVisitor)(quantizationMatrixPtr_);
+                }
             }
     };
 

diff --git a/...projects/boosting/src/mlrl/boosting/statistics/statistics_provider_decomposable_dense.cpp b/...projects/boosting/src/mlrl/boosting/statistics/statistics_provider_decomposable_dense.cpp
@@ -41,7 +41,12 @@ namespace boosting {
               std::move(quantizationMatrixPtr), std::move(lossPtr), std::move(evaluationMeasurePtr),
               ruleEvaluationFactory, outputMatrix, std::move(statisticMatrixPtr), std::move(scoreMatrixPtr));
         };
-        quantizationPtr->visitQuantizationMatrix(denseDecomposableMatrixVisitor, {}, {});
+        auto bitDecomposableMatrixVisitor =
+          [&](std::unique_ptr<IQuantizationMatrix<BitDecomposableStatisticView>>& quantizationMatrixPtr) {
+            // TODO Implement
+            throw std::runtime_error("not implemented");
+        };
+        quantizationPtr->visitQuantizationMatrix(denseDecomposableMatrixVisitor, bitDecomposableMatrixVisitor, {}, {});
         return statisticsPtr;
     }
 

diff --git a/...rojects/boosting/src/mlrl/boosting/statistics/statistics_provider_decomposable_sparse.cpp b/...rojects/boosting/src/mlrl/boosting/statistics/statistics_provider_decomposable_sparse.cpp
@@ -124,7 +124,7 @@ namespace boosting {
               std::move(quantizationMatrixPtr), std::move(lossPtr), std::move(evaluationMeasurePtr),
               ruleEvaluationFactory, outputMatrix, std::move(statisticMatrixPtr), std::move(scoreMatrixPtr));
         };
-        quantizationPtr->visitQuantizationMatrix({}, sparseDecomposableMatrixVisitor, {});
+        quantizationPtr->visitQuantizationMatrix({}, {}, sparseDecomposableMatrixVisitor, {});
         return statisticsPtr;
     }
 

diff --git a/...ects/boosting/src/mlrl/boosting/statistics/statistics_provider_non_decomposable_dense.cpp b/...ects/boosting/src/mlrl/boosting/statistics/statistics_provider_non_decomposable_dense.cpp
@@ -155,7 +155,13 @@ namespace boosting {
                       std::move(this->evaluationMeasurePtr_), ruleEvaluationFactory, this->outputMatrix_,
                       std::move(decomposableStatisticMatrixPtr), std::move(this->scoreMatrixPtr_));
                 };
-                quantizationPtr->visitQuantizationMatrix(denseDecomposableMatrixVisitor, {}, {});
+                auto bitDecomposableMatrixVisitor =
+                  [&](std::unique_ptr<IQuantizationMatrix<BitDecomposableStatisticView>>& quantizationMatrixPtr) {
+                    // TODO Implement
+                    throw std::runtime_error("not implemented");
+                };
+                quantizationPtr->visitQuantizationMatrix(denseDecomposableMatrixVisitor, bitDecomposableMatrixVisitor,
+                                                         {}, {});
                 return statisticsPtr;
             }
     };
@@ -198,7 +204,7 @@ namespace boosting {
               std::move(quantizationMatrixPtr), std::move(lossPtr), std::move(evaluationMeasurePtr),
               ruleEvaluationFactory, outputMatrix, std::move(statisticMatrixPtr), std::move(scoreMatrixPtr));
         };
-        quantizationPtr->visitQuantizationMatrix({}, {}, denseNonDecomposableMatrixVisitor);
+        quantizationPtr->visitQuantizationMatrix({}, {}, {}, denseNonDecomposableMatrixVisitor);
         return statisticsPtr;
     }