fix: add option to reconnect if connack has an error code

[mgabeler-lee-6rs]

fixes #1947

• Not sure about the naming of the new option
• New option defaulting disabled to avoid surprise in consumers, but there's an argument to defaulting it on
• Needs tests
• Add documentation

[robertsLando]

The option name looks good to me. Remember to add tests and also docs

[mgabeler-lee-6rs]

@robertsLando ✔️

I noticed the first pass the CI tests failed for various reasons that ... don't seem related to any changes I made? Esp. the internal error within the codecov uploader.

Edit: new runs failed the same way

[robertsLando]

@mgabeler-lee-6rs I still don't understand why ci fails, could you try removing the test and push? Just to see if that's the reason

[mgabeler-lee-6rs]

Trying that, but somehow I suspect that the problem is more likely related to building/uploading from a fork?

[mgabeler-lee-6rs]

Was going to suggest contacting codecov for help, but I noticed this is using the nodejs uploader, which is deprecated to the point that the repo is archived

Might be worth looking into the github action they provide for this now

[robertsLando]

That's what I tried here: #1943

But no clue why when I add that action workflow remains in wait state for no reason

[mgabeler-lee-6rs]

checks on that PR show:

Annotations
1 error
Error
codecov/codecov-action@v4 is not allowed to be used in mqttjs/MQTT.js. Actions in this workflow must be: within a repository owned by mqttjs, created by GitHub, or matching the following: mqttjs-test, npm-publish, release-it, semantic-pr, amannn/action-semantic-pull-request@*.

Probably some repo security setting?

[robertsLando]

Oh god thanks sooo much for that! I think I lost 4 hours trying to debug that and I totally forgot we have some restrictions on actions that can run.... Could you tell me where you got those errors? I wan't able to see them

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (1eed1b6) to head (5d8377f).

Files with missing lines	Patch %	Lines
src/lib/handlers/connack.ts	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   81.18%   81.07%   -0.12%     
==========================================
  Files          24       24              
  Lines        1467     1469       +2     
  Branches      348      349       +1     
==========================================
  Hits         1191     1191              
- Misses        192      193       +1     
- Partials       84       85       +1     

Flag	Coverage Δ
unittests	81.07% <0.00%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[robertsLando]

Ok I fixed tests and did a minor refactor, could you please fix conflicts? I moved all tests under test/node folder for consistency

[mgabeler-lee-6rs]

Could you tell me where you got those errors? I wan't able to see them

I clicked into the Checks tab on the PR, and from there (on one of the older commits that failed), into the MQTT.js Tests on the left bar, which had a 🗨️ icon, which takes me to a page like https://github.com/mqttjs/MQTT.js/actions/runs/11968792492 which has that error at the bottom under the Annotations header.

could you please fix conflicts?

On it!