Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pushsafer] Add configuration options "Confirm", "Answer Options", and "Force Answers" #630

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

appzer
Copy link
Contributor

@appzer appzer commented Mar 12, 2023

Adding options to use Pushsafer's Confirm, Answer Options, and Force Answer features. The corresponding parameter names are cr, ao, and af.

@amotl here the new pull request

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Kevin,

thank you for submitting your improvements to the Pushsafer adapter once more. I think we will only need to bring in the corresponding improvements to the v2-style configuration layout for Pushsafer, as implemented by GH-629. It will be significantly less confusing for future users of mqttwarn.

With kind regards,
Andreas.

mqttwarn/services/pushsafer.py Outdated Show resolved Hide resolved
@amotl amotl changed the title Update pushsafer.py [Pushsafer] Add configuration options "Confirm", "Answer Options", and "Force Answers" Mar 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Merging #630 (2cde1fc) into main (142b79e) will increase coverage by 0.01%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   40.93%   40.94%   +0.01%     
==========================================
  Files          83       83              
  Lines        3750     3756       +6     
==========================================
+ Hits         1535     1538       +3     
- Misses       2215     2218       +3     
Flag Coverage Δ
unittests 40.94% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqttwarn/services/pushsafer.py 95.89% <50.00%> (-4.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amotl amotl marked this pull request as draft March 12, 2023 18:01
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The corresponding parameter names are `cr`, `ao`, and `af`.
@amotl
Copy link
Member

amotl commented Mar 13, 2023

Hi Kevin,

after bringing in GH-629, I've adjusted your branch to accompany for the v2 configuration layout improvements, and by adding corresponding software tests.

With kind regards,
Andreas.

@amotl amotl merged commit 3092029 into mqtt-tools:main Mar 13, 2023
@amotl
Copy link
Member

amotl commented Mar 13, 2023

Now that this has been merged, you are welcome to test it 1. For doing that easily, you can install the package from the Git repository. Please report back if you think everything is working well, so we can run another release of mqttwarn, including your improvements.

pip install --upgrade git+https://github.com/jpmens/mqttwarn

Footnotes

  1. When doing it, I am kindly asking to use the new configuration layout already, as outlined within the documentation 2.

  2. https://github.com/jpmens/mqttwarn/blob/main/HANDBOOK.md#pushsafer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants