-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pushsafer] Add configuration options "Confirm", "Answer Options", and "Force Answers" #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Kevin,
thank you for submitting your improvements to the Pushsafer adapter once more. I think we will only need to bring in the corresponding improvements to the v2-style configuration layout for Pushsafer, as implemented by GH-629. It will be significantly less confusing for future users of mqttwarn.
With kind regards,
Andreas.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 40.93% 40.94% +0.01%
==========================================
Files 83 83
Lines 3750 3756 +6
==========================================
+ Hits 1535 1538 +3
- Misses 2215 2218 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The corresponding parameter names are `cr`, `ao`, and `af`.
Hi Kevin, after bringing in GH-629, I've adjusted your branch to accompany for the v2 configuration layout improvements, and by adding corresponding software tests. With kind regards, |
Now that this has been merged, you are welcome to test it 1. For doing that easily, you can install the package from the Git repository. Please report back if you think everything is working well, so we can run another release of mqttwarn, including your improvements. pip install --upgrade git+https://github.com/jpmens/mqttwarn Footnotes
|
Adding options to use Pushsafer's Confirm, Answer Options, and Force Answer features. The corresponding parameter names are
cr
,ao
, andaf
.@amotl here the new pull request