Merge pull request #26 from cwyyue/feat-propType-test-doc

feat: props支持ts
mpx-ecology · Jul 5, 2024 · 432bf26 · 432bf26
2 parents d915030 + 5721775
commit 432bf26
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/docs/rules/valid-properties.md b/docs/rules/valid-properties.md
@@ -35,6 +35,16 @@ description: 校验properties有效值
       }
     }
   })
+  // ✓ PropType ts 
+  createComponent({
+    properties: {
+      propsA: {
+        type: String as PropType<Str>,
+        value: ""
+      },
+      propsB: Object as PropType<Obj>
+    }
+  })
 
   // ✗ BAD
   createComponent({

diff --git a/lib/rules/valid-properties.js b/lib/rules/valid-properties.js
@@ -83,8 +83,7 @@ function validProp(node, context, allowKeys) {
       })
     }
   } else if (
-    node.value.type !== 'Identifier' &&
-    node.value.type !== 'TSAsExpression'
+    !(node.value.type === 'Identifier' || node.value.type === 'TSAsExpression')
   ) {
     return context.report({
       node,

diff --git a/tests/lib/rules/valid-properties.js b/tests/lib/rules/valid-properties.js
@@ -7,7 +7,7 @@
 // ------------------------------------------------------------------------------
 // Requirements
 // ------------------------------------------------------------------------------
-
+const tsParser = require.resolve('@typescript-eslint/parser')
 const rule = require('../../../lib/rules/valid-properties')
 const RuleTester = require('eslint').RuleTester
 
@@ -42,11 +42,15 @@ ruleTester.run('valid-properties', rule, {
               type: String,
               optionalTypes:[Number],
               observer: ()=>{}
+            },
+            propsD: Object as PropType<Obj>,
+            propsE: {
+              type: Object as Obj
             }
-
           }
         })
-        `
+        `,
+      parser: tsParser
     },
     {
       filename: 'test.mpx',