vo: add --video-recenter #15320
Open
vo: add --video-recenter #15320
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na-na-hi
reviewed
Nov 16, 2024
video/out/vo.c
Outdated
| if (!vo->params || !vo->opts->recenter) | ||
| return; | ||
|
|
||
| struct MPContext *mpctx = (struct MPContext *)vo->extra.wakeup_ctx; |
There was a problem hiding this comment.
VO shouldn't access mpctx. It's for main player thread only.
There was a problem hiding this comment.
How can se signal the property notifications?
There was a problem hiding this comment.
How can se signal the property notifications?
These options are part of the VO sub option so they can be updated with config cache. window-maximized etc are updated in this way in VO implementations.
guidocella
force-pushed
the
video-recenter
branch
2 times, most recently
from
d2662c3
to
62dd0a5
Compare
This resets --video-align-x and --video-align-y to 0 when the video becomes smaller than the OSD in the respective direction, e.g. by zooming out. Unlike doing this by observing osd-dimensions in a script, this is done before rerendering, so you don't see the image being rendered uncentered for an instant after zooming out, before being rerendered centered. Defaults to yes.
guidocella
force-pushed
the
video-recenter
branch
from
62dd0a5
to
ad98eb5
Compare
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resets
--video-align-xand--video-align-yto 0 when the video becomes smaller than the OSD in the respective direction, e.g. by zooming out.Unlike doing this by observing osd-dimensions in a script, this is done before rerendering, so you don't see the image being rendered not centered for an instant after zooming out before being rerendered centered.
Defaults to yes.