Update Xcode versions for apple-clang builds #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpusz Let me know what you think and if we should drop 15.4 from the matrix — not sure what resources are costing us for adding to the test matrix. |
Since mp-units requires at least Xcode 15 we should have coverage on the latest compilers for operating system versions for macOS 13 (Ventura) and macOS 14 (Sequoia) as those are the operating systems with necessary compilers that our users would be using. Now build with Xcode 15.2 instead of 15.0.1 which last version supported on macOS 13. Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds. Since Xcode 16.1 is new most of our clients using macOS 14 would might more likely be using Xcode 15.4. There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so perhaps we should drop 15.4 if adding three apple-clang builds is not worth the resources.
rothmichaels
force-pushed
the
feature/update-apple-clang-test-matrix
branch
from
4cf2ff5
to
a086c18
Compare
|
I do not know what are the differences between 15.2 and 15.4. Are there any significant apple-clang version changes? Also, could you please check if any of the new versions support additional features from https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mp-units requires at least Xcode 15 we should have coverage on the latest compilers for operating system versions for macOS 13 (Ventura) and macOS 14 (Sequoia) as those are the operating systems with necessary compilers that our users would be using.
Now build with Xcode 15.2 instead of 15.0.1 which last version supported on macOS 13.
Add a build for Xcode 15.4 and Xcode 16.1 for testing macOS 14 builds. Since Xcode 16.1 is new most of our clients using macOS 14 would might more likely be using Xcode 15.4.
There might not be much C++ changes between Xcode 15.2 and Xcode 15.4 so perhaps we should drop 15.4 if adding three apple-clang builds is not worth the resources.