[msvc] changes to make library compatible with msvc compiler (194) #607

czjhoppe · 2024-09-03T12:01:41Z

This PR enables the use of this library with the MSVC compiler in version 194. To prevent the code in the example and test folders from becoming ugly, the scope of this PR is limited to the library part. To compile tests or examples with MSVC, please refer to the following links: https://github.com/czjhoppe/mp-units/tree/master-msvc-194 or https://github.com/czjhoppe/mp-units/tree/2.2-msvc-194.

Changes:

Added MSVC version 194 to compatible compiler in conanfile.py.
Removed some unreachable code in fmt.h to silence the warning in one case.
Added MP_UNITS_IS_CONST_EXPR which can be used in cases where MSVC encounters a parser error and expects an expression.
Added MP_UNITS_IS_VALUE which can be used in cases where MSVC prefers the type instead of the value for non-type template parameters.
Added MP_UNITS_IS_CONST_EXPR which can be used in cases where MSVC does not recognize that the underlying code is a constant expression.
Changed some short names because they hide a global identifier for MSVC.

Additional explanations:

sudo_cast.h: MSVC has problems with requires { typename std::common_type_t<T, Other>; } in cases with no common type.
format.h: The iterator for string_view is not castable to char*.
-quantity.h: operator*= behaves differently for runtime and compile time.
quantity_point.h: Some weird problem with PO.
ostream.h: the requires requires clause causes an internal compiler error for msvc

…pile time (issue reported)

the type and not the value. (Issue reported)

…le for msvc

… in mdspan

…found) replace with concept has_common_type

…y" with extra concept

…oint_origin where needed

…o a const. (caused by read of variable outside its lifetime)

src/core/include/mp-units/bits/fmt.h

src/core/include/mp-units/bits/hacks.h

src/core/include/mp-units/bits/sudo_cast.h

src/core/include/mp-units/format.h

src/core/include/mp-units/framework/quantity_spec.h

src/core/include/mp-units/framework/unit.h

src/core/include/mp-units/ostream.h

test_package/test_package.cpp

…stexpr function

src/core/include/mp-units/framework/quantity_spec.h

src/core/include/mp-units/framework/unit.h

This reverts commit e3034c5, reversing changes made to 8be458b.

…nches

…f using MP_UNITS_IS_CONST_EXPR_WORKAROUND

mpusz

Awesome!!! This is a huge work! Thank you!

https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445

czjhoppe · 2024-09-10T10:38:02Z

There is one last unresolved conversation.

mpusz · 2024-09-10T10:52:11Z

Yes, I know. I want to leave it and check by myself after merge 😉

czjhoppe added 27 commits September 3, 2024 09:42

[msvc][fix] msvc needs explicit namespace for some using-declarations

72e03f4

[msvc][fix] some short names hide global identifier

33837c5

[msvc][fix] msvc compiler has different behaviour for *= and * at com…

aa26488

…pile time (issue reported)

[msvc][fix] some short names hide global identifier

5d3ed20

[msvc][fix] a lot of brackets where msvc prefers

30ac288

the type and not the value. (Issue reported)

[msvc][fix] return type of chrono_literal "s" is not defined. Is doub…

d491758

…le for msvc

[msvc][fix] CTAD for quantity_point does not work.

e9ad43a

[msvc][cmake] disable linear_algebra_test.cpp tests because of errors…

1913fbe

… in mdspan

[msvc][fix] some more errros in examples

482150e

[mscv][fix] string_view iterator is not castalbe to char

19e358e

[msvc][fix] resolve ambigious call to find_first_of

464c555

[msvc][fix] msvc complains about requires expression (no common type …

5e657ba

…found) replace with concept has_common_type

[msvc][fix] internal compiler error for requires expression. "simplif…

3d32d5d

…y" with extra concept

[mscv][fix] weird problem with PO in quantity_point.h. replace with p…

924782f

…oint_origin where needed

[msvc][fix] disable C4702 unreachable code

cea5d70

[msvc][fix] compiler does not get that expression can be evalutated t…

3a6fc90

…o a const. (caused by read of variable outside its lifetime)

[msvc][fix] parse error in refernce.h. resolved with more brackets.

918a8b7

💥 [msvc][conan] enable msvc with version 194.

4b61716

[msvc][fix] update changes for master

4d71573

[msvc][fmt] diable warning in smalest scope

e258009

[hacks] add MP_UNITS_EXPRESSION

5ae1304

[hacks] add MP_UNITS_IS_VALUE

a89bfc6

[hacks] add MP_UNITS_IS_CONST_EXPR(from)

48c4f29

[naming] change some more names

b5c9dca

[clang-format]

0b0d334

[msvc][conan] update test_package.cpp

61ada08

[msvc][fix] revert changes in example and test folder

af077ef

mpusz requested changes Sep 3, 2024

View reviewed changes

czjhoppe added 2 commits September 4, 2024 09:28

[PR] change disable error to macro

d1897b1

[PR] remove MP_UNITS_TYPENAME

d18bb28

czjhoppe added 5 commits September 4, 2024 09:37

[PR] rename macros to match naming conventions for workaround

712afc3

[PR] move is_mp_units_stream to detail and change from concept to con…

b05b379

…stexpr function

[msvc] remove MP_UNITS_CONSTRAINED_AUTO_WORKAROUND

8be458b

Merge branch 'master-msvc-194' into master-msvc-194-only-lib

3174291

[clang-format]

93af5db

mpusz requested changes Sep 4, 2024

View reviewed changes

src/core/include/mp-units/framework/quantity_spec.h Outdated Show resolved Hide resolved

src/core/include/mp-units/framework/quantity_spec.h Outdated Show resolved Hide resolved

src/core/include/mp-units/framework/unit.h Outdated Show resolved Hide resolved

czjhoppe added 12 commits September 9, 2024 11:49

Merge branch 'master-msvc-194-only-lib' into master-msvc-194

e3034c5

Merge remote-tracking branch 'mpusz/master' into master-msvc-194

1d0dbf4

Revert "Merge branch 'master-msvc-194-only-lib' into master-msvc-194"

aebf55c

This reverts commit e3034c5, reversing changes made to 8be458b.

[msvc][fix] remvoe MP_UNITS_IS_CONST_EXPR_WORKAROUND in constexpr bra…

9ce76ed

…nches

[msvc][fix][unit.h] move requires before function signature instead o…

eaed061

…f using MP_UNITS_IS_CONST_EXPR_WORKAROUND

[msvc][fix] add Workaround Macro to conan test-package

5254467

[msvc][fix] remove all unnecessary MP_UNITS_IS_CONST_EXPR_WORKAROUND

3da6db7

[msvc][fix] remove MP_UNITS_IS_CONST_EXPR_WORKAROUND

ee4a706

[clang-format]

f651438

[msvc][fix] revert changes in example and test folder

413966e

Merge branch 'master' into master-msvc-194-only-lib

0532f41

[msvc][fix] remove MP_UNITS_CONSTRAINED_AUTO_WORKAROUND in example

4f4da58

mpusz previously approved these changes Sep 10, 2024

View reviewed changes

czjhoppe added 2 commits September 10, 2024 11:01

[msvc][fix] add Todo comment for bug

5ecb6c2

https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445

clang-format

329b17e

czjhoppe dismissed mpusz’s stale review via 329b17e September 10, 2024 09:14

mpusz approved these changes Sep 10, 2024

View reviewed changes

mpusz merged commit 39d735f into mpusz:master Sep 10, 2024
299 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[msvc] changes to make library compatible with msvc compiler (194) #607

[msvc] changes to make library compatible with msvc compiler (194) #607

czjhoppe commented Sep 3, 2024

mpusz left a comment

czjhoppe commented Sep 10, 2024

mpusz commented Sep 10, 2024 •

edited

Loading

[msvc] changes to make library compatible with msvc compiler (194) #607

[msvc] changes to make library compatible with msvc compiler (194) #607

Conversation

czjhoppe commented Sep 3, 2024

mpusz left a comment

Choose a reason for hiding this comment

czjhoppe commented Sep 10, 2024

mpusz commented Sep 10, 2024 • edited Loading

mpusz commented Sep 10, 2024 •

edited

Loading