Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure mp-units are compatible with std::atomic #554

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Ensure mp-units are compatible with std::atomic #554

merged 3 commits into from
Feb 10, 2024

Conversation

NAThompson
Copy link
Contributor

No description provided.

@NAThompson
Copy link
Contributor Author

@mpusz : Perhaps seems trivial, but I got ground to a halt trying to get boost.units to work on this very problem.

mpusz
mpusz reviewed Feb 10, 2024
View reviewed changes
test/runtime/atomic_test.cpp Outdated Show resolved Hide resolved
@mpusz
Copy link
Owner

mpusz commented Feb 10, 2024

std::atomic does not have operator==, so the test will never compile.

mpusz
mpusz reviewed Feb 10, 2024
View reviewed changes
test/runtime/atomic_test.cpp Outdated Show resolved Hide resolved
mpusz
mpusz approved these changes Feb 10, 2024
View reviewed changes
Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpusz mpusz merged commit 2889658 into mpusz:master Feb 10, 2024
33 checks passed
@NAThompson NAThompson deleted the atomic_compatibility branch February 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpusz mpusz mpusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NAThompson @mpusz