Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point classification functions #528

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Conversation

NAThompson
Copy link
Contributor

Add the ability for isnan, isfinite, and isinf to work on dimensioned quantities.

Add the ability for `isnan`, `isfinite`, and `isinf` to work on dimensioned quantities.
@NAThompson
Copy link
Contributor Author

@mpusz : Hopefully much less complicated than the last one-this is ready to go.

Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpusz mpusz merged commit 84e6a6d into mpusz:master Dec 16, 2023
53 checks passed
@NAThompson NAThompson deleted the classify branch December 16, 2023 16:41
@NAThompson
Copy link
Contributor Author

@mpusz : Do you think this-along with the fma work-is big enough to push a new release to conan?

@mpusz
Copy link
Owner

mpusz commented Dec 17, 2023

I do not think that it is big enough and pushing a new release to Conan and Compiler Explorer is not that trivial. For example, we still do not have mp-units 2.1 in Conan because of some CI issues and I did not have time to add it to CE.

I would prefer to wait for a few more changes before we provide another release. Until then you can use our own Conan server to get the latest stable version. Does it work for you?

@NAThompson
Copy link
Contributor Author

Does it work for you?

@mpusz : Absolutely-my intention is not to increase workload but merely check if something is trivial. Hopefully conan can make this process easier . . .

@mpusz
Copy link
Owner

mpusz commented Dec 17, 2023

It is not that hard at all. I just have to submit short PRs to both ConanCenter and 2 repos from the Compiler Explorer for each new release. If everything works fine (and it should when the V2 design and compiler support will settle down), it should not take too much time. Unfortunately, this is not the case yet.

But you are right. We should release mp-units more often, and I intend to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants