refactor: explicit type of op/ for quantity and reference repla…

…ced with constrained placeholder This prevents additional instantiations of inversed quantities
mpusz · Nov 16, 2024 · b00d061 · b00d061
1 parent 1be54cb
commit b00d061
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/include/mp-units/framework/quantity.h b/src/core/include/mp-units/framework/quantity.h
@@ -584,7 +584,7 @@ class quantity {
   template<typename Value, std::derived_from<quantity> Q>
     requires(!Quantity<Value>) &&
             (!Reference<Value>) && detail::InvokeResultOf<quantity_spec, std::divides<>, const Value&, Rep>
-  [[nodiscard]] friend constexpr QuantityOf<inverse(quantity_spec)> auto operator/(const Value& val, const Q& q)
+  [[nodiscard]] friend constexpr Quantity auto operator/(const Value& val, const Q& q)
   {
     return ::mp_units::quantity{val / q.numerical_value_ref_in(unit), ::mp_units::one / R};
   }

diff --git a/src/core/include/mp-units/framework/reference.h b/src/core/include/mp-units/framework/reference.h
@@ -199,7 +199,7 @@ template<typename FwdRep, Reference R, RepresentationOf<get_quantity_spec(R{})>
 
 template<typename FwdRep, Reference R, RepresentationOf<get_quantity_spec(R{})> Rep = std::remove_cvref_t<FwdRep>>
   requires(!detail::OffsetUnit<decltype(get_unit(R{}))>)
-[[nodiscard]] constexpr quantity<inverse(R{}), Rep> operator/(FwdRep&& lhs, R)
+[[nodiscard]] constexpr Quantity auto operator/(FwdRep&& lhs, R)
 {
   return quantity{std::forward<FwdRep>(lhs), inverse(R{})};
 }