Skip to content

Commit

Permalink
fix: bugs introduced by the flake8 recommendations fixed and those wa…
Browse files Browse the repository at this point in the history
…rnings are ignored from now on
  • Loading branch information
mpusz committed Apr 17, 2024
1 parent 4c9570e commit 94b4d0a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
7 changes: 7 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
[flake8]
max-line-length = 120
ignore =
# comparison to None should be 'if cond is None:'
E711,
# comparison to True should be 'if cond is True:' or 'if cond:'
E712,
# line break before binary operator
W503
6 changes: 3 additions & 3 deletions conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def _check_feature_supported(self, name, feature_name=name):

# check compiler version
min_version = feature["compiler"].get(str(compiler))
if min_version is None:
if min_version == None:
# not tested compiler being used - use at your own risk
return
if min_version == "":
Expand All @@ -166,7 +166,7 @@ def _is_feature_enabled(self, name):
feature = self._feature_compatibility[feature_name]
min_version = feature["compiler"].get(str(compiler))
return bool(
opt is True
opt == True
or (
opt == "auto"
and min_version
Expand Down Expand Up @@ -211,7 +211,7 @@ def build_requirements(self):
def validate(self):
self._check_feature_supported("mp-units", "minimum_support")
for key, value in self._option_feature_map.items():
if self.options.get_safe(key) is True:
if self.options.get_safe(key) == True:
self._check_feature_supported(key, value)

def layout(self):
Expand Down

0 comments on commit 94b4d0a

Please sign in to comment.