[msvc][fix] add Todo comment for bug

https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445
mpusz · Sep 10, 2024 · 5ecb6c2 · 5ecb6c2
1 parent 4f4da58
commit 5ecb6c2
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/core/include/mp-units/framework/quantity.h b/src/core/include/mp-units/framework/quantity.h
@@ -435,6 +435,8 @@ class quantity {
     }
   friend constexpr decltype(auto) operator*=(FwdQ&& lhs, const Value& v)
   {
+    // TODO use *= when compiiler bug is resolved:
+    // https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445
     lhs.numerical_value_is_an_implementation_detail_ = lhs.numerical_value_is_an_implementation_detail_ * v;
     return std::forward<FwdQ>(lhs);
   }
@@ -447,6 +449,8 @@ class quantity {
     }
   friend constexpr decltype(auto) operator*=(FwdQ1&& lhs, const Q2& rhs)
   {
+    // TODO use *= when compiiler bug is resolved:
+    // https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445
     lhs.numerical_value_is_an_implementation_detail_ =
       lhs.numerical_value_is_an_implementation_detail_ * rhs.numerical_value_is_an_implementation_detail_;
     return std::forward<FwdQ1>(lhs);
@@ -461,6 +465,8 @@ class quantity {
   friend constexpr decltype(auto) operator/=(FwdQ&& lhs, const Value& v)
   {
     MP_UNITS_EXPECTS_DEBUG(v != quantity_values<Value>::zero());
+    // TODO use /= when compiiler bug is resolved:
+    // https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445
     lhs.numerical_value_is_an_implementation_detail_ = lhs.numerical_value_is_an_implementation_detail_ / v;
     return std::forward<FwdQ>(lhs);
   }
@@ -474,6 +480,8 @@ class quantity {
   friend constexpr decltype(auto) operator/=(FwdQ1&& lhs, const Q2& rhs)
   {
     MP_UNITS_EXPECTS_DEBUG(rhs != rhs.zero());
+    // TODO use /= when compiiler bug is resolved:
+    // https://developercommunity.visualstudio.com/t/Discrepancy-in-Behavior-of-operator-an/10732445
     lhs.numerical_value_is_an_implementation_detail_ =
       lhs.numerical_value_is_an_implementation_detail_ / rhs.numerical_value_is_an_implementation_detail_;
     return std::forward<FwdQ1>(lhs);