Execution context warning #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display a warning message if the current browser context is not considered as "secure".
mluisbrown
approved these changes
Feb 8, 2023
Co-authored-by: Michael Brown <[email protected]>
Co-authored-by: Michael Brown <[email protected]>
|
@mluisbrown Thanks for the review. |
The same context logic testing cannot be used on both creator and secret as creator need HTTPS at any time (due to fetch() method). I also removed the localhost notion because it's confusing and serving content over HTTPS needs to be recommended at any time.
TeddyBear06
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let summarize my proposal #36 in two parts as creator and secret does not meets the same requirements.
A - Concerning the creator:
Requires HTTPS at any time.
B - Concerning the secret:
Requires a "secure context" (given by the isSecureContext property).