Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versionable): latest versions list #78

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

benms
Copy link

@benms benms commented Mar 25, 2021

description #77

done: recheck tests on local environment

@codecov-io
Copy link

codecov-io commented Mar 25, 2021

Codecov Report

Merging #78 (176a2d9) into master (b3cbcff) will decrease coverage by 1.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     99.15%   97.41%   -1.75%     
- Complexity       45       46       +1     
============================================
  Files             3        3              
  Lines           119      116       -3     
============================================
- Hits            118      113       -5     
- Misses            1        3       +2     
Impacted Files Coverage Δ Complexity Δ
src/Mpociot/Versionable/VersionableTrait.php 100.00% <100.00%> (ø) 32.00 <1.00> (+1.00)
src/Mpociot/Versionable/Version.php 91.17% <0.00%> (-5.89%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cbcff...176a2d9. Read the comment docs.

@nonoesp
Copy link
Collaborator

nonoesp commented Apr 19, 2021

Hey, @benms! Thanks for these changes! Clever solution.

Are you able to re-check the tests on your local environments?

@benms
Copy link
Author

benms commented Apr 20, 2021

Hey @nonoesp, tests passed on local env.

Run tests screenshot

@nonoesp nonoesp merged commit 434f1d1 into mpociot:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants