Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create initial version #100

Merged
merged 3 commits into from
Mar 27, 2023
Merged

create initial version #100

merged 3 commits into from
Mar 27, 2023

Conversation

iateadonut
Copy link
Contributor

@iateadonut iateadonut commented Mar 22, 2023

Hi - this is what we talked about here:

#99

@iateadonut
Copy link
Contributor Author

PR contains:
methods:
initializeVersionOnAllRows()
createInitialVersion()

tests for those methods
updates to the README.md file

Why not run createInitialVersion() on update? Is there any case where a user would not want the initial version created when they run update?

@nonoesp
Copy link
Collaborator

nonoesp commented Mar 27, 2023

Why not run createInitialVersion() on update? Is there any case where a user would not want the initial version created when they run update?

I'm not sure. This library initially assumed you'd start with a model that hadn't been populated on the database, but it makes sense to add versioning to an existing project.

@nonoesp nonoesp merged commit 3d0f883 into mpociot:master Mar 27, 2023
@nonoesp
Copy link
Collaborator

nonoesp commented Mar 27, 2023

Released as 4.4.0. Thanks @iateadonut. Note that I've renamed the static method to Model::initializeVersions().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants