Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml and support Cython 3 #30

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Add pyproject.toml and support Cython 3 #30

merged 3 commits into from
Apr 24, 2024

Conversation

dalcinl
Copy link
Member

@dalcinl dalcinl commented Aug 10, 2023

No description provided.

@benlandrum
Copy link

Looks like you have the rest of this. Is the MacOS ARM issue new? I don't remember seeing that one previously.

@dalcinl
Copy link
Member Author

dalcinl commented Apr 23, 2024

Looks like you have the rest of this

I still have to fix Azure Pipelines. I'll take a look tomorrow morning. I'm not sure whether to keep insisting with conda-forge environments, of just use the same approach as here, but for the older Python versions (like I do in mpi4py).

Is the MacOS ARM issue new?

The ARM macOS images do not have the older versions of Python. Other than that, there are no issues. What do you meant exactly?

@benlandrum
Copy link

The ARM macOS images do not have the older versions of Python. Other than that, there are no issues. What do you meant exactly?

Yes, that's the issue. I had for instance macos-latest and Python 3.7 working a few weeks ago with my draft, when macos-latest was 12.7.4 (see here). Now on 14.4.1 I get The version '3.7' with architecture 'arm64' was not found for macOS 14.4.1.

@dalcinl dalcinl force-pushed the dalcinl/cython3 branch 8 times, most recently from df58594 to c90a127 Compare April 24, 2024 16:36
Copy link

codecov bot commented Apr 24, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dalcinl dalcinl force-pushed the dalcinl/cython3 branch 2 times, most recently from 4f515d8 to b23b870 Compare April 24, 2024 16:54
@dalcinl
Copy link
Member Author

dalcinl commented Apr 24, 2024

For the time being, testing of all he IO stuff will not run and is uncovered.
The build fixes and Cython 3 updates are more important that 100% test coverage.

@dalcinl dalcinl merged commit ad9a610 into master Apr 24, 2024
13 of 14 checks passed
@dalcinl dalcinl deleted the dalcinl/cython3 branch April 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants