Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static version #7

Open
wants to merge 6 commits into
base: static_version
Choose a base branch
from
Open

Static version #7

wants to merge 6 commits into from

Conversation

ivastar
Copy link
Contributor

@ivastar ivastar commented Feb 7, 2024

Creating a branch with static versioning.

@ivastar
Copy link
Contributor Author

ivastar commented Feb 7, 2024

@jdavies-st is this all that is needed to undo the dynamic versioning?

jdavies-st
jdavies-st reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You'll also want to remove setuptools_scm as a build dependency under [build-system] requires in pyproject.toml.

And a minor nit below to not use bare excepts in try/except blocks.

src/my_package/__init__.py Outdated Show resolved Hide resolved
@jdavies-st
Copy link
Collaborator

Oh, and I tested these changes on the package I made from the template last Friday, and it works like a charm. 🚀

@ivastar
Copy link
Contributor Author

ivastar commented Feb 12, 2024

@jdavies-st is this better?

@jdavies-st
Copy link
Collaborator

Add a blank line before [project.urls] in pyproject.toml and a blank line at the end of __init__.py then you're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavies-st jdavies-st jdavies-st left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivastar @jdavies-st