Increase cyclomatic complexity limit

getDirect() is necessarily complex
mpetrovich · Jun 9, 2021 · 3ddd8ef · 3ddd8ef
1 parent d9e514f
commit 3ddd8ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/phpcs.xml b/phpcs.xml
@@ -21,7 +21,7 @@
 	<rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman"/>
 	<rule ref="Generic.Metrics.CyclomaticComplexity">
 		<properties>
-			<property name="complexity" value="6"/>
+			<property name="complexity" value="7"/>
 			<property name="absoluteComplexity" value="10"/>
 		</properties>
 	</rule>

diff --git a/src/getDirect.php b/src/getDirect.php
@@ -36,10 +36,8 @@
 function getDirect($input, $key, $default = null)
 {
 	if (!is_string($key) && !is_numeric($key) && !is_null($key)) {
-		return $default;
-	}
-
-	if (is_null($input)) {
+		$value = $default;
+	} elseif (is_null($input)) {
 		$value = $default;
 	} elseif ($input instanceof \ArrayAccess && $input->offsetExists($key)) {
 		$value = $input[$key];