Change lazy-loading-attr to also cover iframes #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantek
requested changes
Oct 19, 2023
There was a problem hiding this comment.
These changes look good.
I would additionally suggest updating the mdnUrl to https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#images_and_iframes which covers both images and iframes
Ideally we'd link to both mozBugUrls (image and iframe lazy loading) but I'm not sure if multiple bug URLs are supported
zcorpan
commented
Oct 24, 2023
|
@tantek changed mdnUrl. Yeah I think we can only point to one bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #840