Fix Jetty intermediate/old configs for TLSv1.3-only clients
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
added a commit
to janbrasna/ssl-config-generator
that referenced
this pull request
Jan 6, 2024
janbrasna
added
bug
janbrasna
changed the title
intermediate/old configs for TLSv1.3-only clients
gstrauss
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
With any
output.cipherspresent, for TLSv1.3 to work also theoutput.cipherSuiteshave to be provided for TLSv1.3 handshakes not to fail (i.e. whenIncludeCipherSuitesdefined, also the TLSv1.3 compatible suites as defined in RFC 8446 have to be explicitly set, or TLSv1.3-only clients won't be able to connect).Fixes
intermediateandoldconfigs.Support for
*_CHACHA20_POLY1305_*was added in 11.0.13 JDK-8140466 but since it was not addressed for TLSv12 suites before, I haven't added anything mentioning the JSSE support for TLSv13 either — if that errors out for someone running older revisions, feel free to open separate issue for that; however we're not comparing such versions in the logic here, so it may only warrant a config comment of sorts…