Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty TLS 1.3 CipherSuites #154

Closed
jonah-iden opened this issue Jul 12, 2021 · 4 comments · Fixed by #226
Closed

Jetty TLS 1.3 CipherSuites #154

jonah-iden opened this issue Jul 12, 2021 · 4 comments · Fixed by #226
Assignees
Labels
bug Something isn't working P1 Priority: 1

Comments

@jonah-iden
Copy link

The generated intermediate Jetty SSL Configuration does not work with TLS1.3 because it specifies IncludeCipherSuites without specifing any TLS1.3 compatible ones as defined in RFC 8446. This of course would lead to a failed SSL Handshake with the Jetty server if only TLS1.3 was supported and leads to a downgrade to TLS1.2 otherwise.

@mkjor
Copy link

mkjor commented Dec 17, 2021

I ran into the same problem. The two Cipher Suites TLS_AES_128_GCM_SHA256 and TLS_AES_256_GCM_SHA384 should be added for TLSv1.3.

@gene1wood gene1wood added the bug Something isn't working label Jul 28, 2022
@janbrasna
Copy link
Collaborator

@jonah-iden @mkjor Thanks for catching this! Could you please try the configs from preview build: https://deploy-preview-24--mozsslconf-dev.netlify.app/#server=jetty that add the three default TLSv1.3 cipher suites to the top of the list for intermediate and old if that's all what is needed? (modern is left out for defaults…)

@jonah-iden
Copy link
Author

On a first glance this looks good to me, but i sadly don't have a Jetty setup anymore i could test this with

@mozilla mozilla deleted a comment from Hilljackcantspell Jan 5, 2024
@janbrasna
Copy link
Collaborator

Thanks, I was mostly concerned about including TLS_CHACHA20_POLY1305_SHA256 that gained support later for RFC compatibility JDK-8140466 — but the same would apply for already used TLSv1.2 ciphers so I assume if these were okay, probably just an extra comment mentioning 11.0.3 support would suffice. Thanks again for helping out making the configs right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Priority: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants