Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Make results tiltle editable and URL persistent #774

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

enhancement: Make results tiltle editable and URL persistent #774

wants to merge 36 commits into from

Commits on Oct 9, 2024

  1. refactor: replace text with input

    @FatumaA
    FatumaA committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bb6ce4f View commit details
    Browse the repository at this point in the history

  2. fix: Sync URL state and input value

    @FatumaA
    FatumaA committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a62c560 View commit details
    Browse the repository at this point in the history

  3. fix: order imports correctly

    @FatumaA
    FatumaA committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    327c03a View commit details
    Browse the repository at this point in the history

  4. style: Mirror original title styles

    @FatumaA
    FatumaA committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1385406 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: persist the URL state and title when page is refreshed

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    282252e View commit details
    Browse the repository at this point in the history

  2. style: remove unused class and its definition

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8093d55 View commit details
    Browse the repository at this point in the history

  3. fix: a11y add hidden label text to input

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0c7a46d View commit details
    Browse the repository at this point in the history

  4. test: update the resultsView corresponding test

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f31e15d View commit details
    Browse the repository at this point in the history

  5. test: update snapshots

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3acd065 View commit details
    Browse the repository at this point in the history

  6. fix: lint

    @FatumaA
    FatumaA committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5c96760 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. feat: extract logic into component

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5623b97 View commit details
    Browse the repository at this point in the history

  2. chore: clean up results main and use new component

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    447de2d View commit details
    Browse the repository at this point in the history

  3. refactor: prefer custom search param hook

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e9483d6 View commit details
    Browse the repository at this point in the history

  4. feat: toggle between the value of label and input

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bfabdad View commit details
    Browse the repository at this point in the history

  5. fix: switch to label on blur too

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    52a16a1 View commit details
    Browse the repository at this point in the history

  6. fix: protect against empty strings

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8e75e50 View commit details
    Browse the repository at this point in the history

  7. test: add testable data attribute to label

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    694e07e View commit details
    Browse the repository at this point in the history

  8. test: update test to look for label data testid attribute

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f33e4ee View commit details
    Browse the repository at this point in the history

  9. test: add draft test for results title component

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    603be9d View commit details
    Browse the repository at this point in the history

  10. chore: remove timeout

    @FatumaA
    FatumaA committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ffddac0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix: use ternary for entire component

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8d4f891 View commit details
    Browse the repository at this point in the history

  2. chore: add wrapper div for testing

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f0168bc View commit details
    Browse the repository at this point in the history

  3. test: update test definition in ResultsView.test

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1633d54 View commit details
    Browse the repository at this point in the history

  4. fix: a11y - add a label on input for screen readers

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6ca4055 View commit details
    Browse the repository at this point in the history

  5. style: add class to span containing the title

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8fa4b94 View commit details
    Browse the repository at this point in the history

  6. refactor: use existing button

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2b3c4aa View commit details
    Browse the repository at this point in the history

  7. chore: remove unused style definition

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4bf4ef4 View commit details
    Browse the repository at this point in the history

  8. chore: remove unused id and class on edit button

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1b2bc64 View commit details
    Browse the repository at this point in the history

  9. fix: wrap the edit button in MUI's icon button component

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2696f6c View commit details
    Browse the repository at this point in the history

  10. style: make text and icon centered

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cdd275f View commit details
    Browse the repository at this point in the history

  11. fix: remove button in button with icon image

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f5588d2 View commit details
    Browse the repository at this point in the history

  12. fix: pass the correct theme mode to ResultsTitle component

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1613663 View commit details
    Browse the repository at this point in the history

  13. fix: handle escape when editing title

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d613e18 View commit details
    Browse the repository at this point in the history

  14. fix: a11y - add focus to input when in edit mode

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6add9ba View commit details
    Browse the repository at this point in the history

  15. test: update tests for ResultsTitle component

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5d801c1 View commit details
    Browse the repository at this point in the history

  16. test: update snapshots in ResultsTable and CompareWithBase tests

    @FatumaA
    FatumaA committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7733853 View commit details
    Browse the repository at this point in the history