-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access the bbox/background data correctly in the MeshShadingPattern
class (issue 18816)
#19305
Conversation
… class (issue 18816) This appears to have regressed in PR 13808, since it removed the `matrix`-entry from array returned by the `MeshShading.prototype.getIR` method *without* also updating the indexes in the `MeshShadingPattern` constructor.
70c2001
to
916fff0
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7cb1f838c92ef38/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8ba286e3a0b594e/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thank you.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7cb1f838c92ef38/output.txt Total script time: 28.35 mins
Image differences available at: http://54.241.84.105:8877/7cb1f838c92ef38/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8ba286e3a0b594e/output.txt Total script time: 53.31 mins
Image differences available at: http://54.193.163.58:8877/8ba286e3a0b594e/reftest-analyzer.html#web=eq.log |
The ref-test "failures" are unrelated to this patch, and are rather caused the Firefox 136 update. /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/83b2ce031964f46/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9c3f00c36eb23da/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/83b2ce031964f46/output.txt Total script time: 16.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9c3f00c36eb23da/output.txt Total script time: 26.62 mins
|
This appears to have regressed in PR #13808, since it removed the
matrix
-entry from array returned by theMeshShading.prototype.getIR
method without also updating the indexes in theMeshShadingPattern
constructor.