Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access the bbox/background data correctly in the MeshShadingPattern class (issue 18816) #19305

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

This appears to have regressed in PR #13808, since it removed the matrix-entry from array returned by the MeshShading.prototype.getIR method without also updating the indexes in the MeshShadingPattern constructor.

… class (issue 18816)

This appears to have regressed in PR 13808, since it removed the `matrix`-entry from array returned by the `MeshShading.prototype.getIR` method *without* also updating the indexes in the `MeshShadingPattern` constructor.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7cb1f838c92ef38/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8ba286e3a0b594e/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/7cb1f838c92ef38/output.txt

Total script time: 28.35 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.241.84.105:8877/7cb1f838c92ef38/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8ba286e3a0b594e/output.txt

Total script time: 53.31 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 17

Image differences available at: http://54.193.163.58:8877/8ba286e3a0b594e/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 573e5f5 into mozilla:master Jan 8, 2025
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

The ref-test "failures" are unrelated to this patch, and are rather caused the Firefox 136 update.

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/83b2ce031964f46/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9c3f00c36eb23da/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/83b2ce031964f46/output.txt

Total script time: 16.74 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9c3f00c36eb23da/output.txt

Total script time: 26.62 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Diamond gradient not displayed
3 participants