Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip LinkAnnotations when collecting field objects (issue 19281) #19289

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

The /Root/AcroForm/Fields array contains a "ridiculous" number of LinkAnnotations, which obviously makes no sense since those are not form fields. To improve performance we'll thus ignore those when collecting the field objects.

The `/Root/AcroForm/Fields` array contains a "ridiculous" number of LinkAnnotations, which obviously makes no sense since those are not form fields.
To improve performance we'll thus ignore those when collecting the field objects.
@mozilla mozilla deleted a comment from moz-tools-bot Jan 4, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Jan 4, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Jan 4, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Jan 4, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4aa7cbb635e9ab3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/547c04f6aa6182c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4aa7cbb635e9ab3/output.txt

Total script time: 27.73 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/547c04f6aa6182c/output.txt

Total script time: 52.14 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/387f6f28918255b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/387f6f28918255b/output.txt

Total script time: 0.86 mins

Published

@timvandermeij timvandermeij merged commit 4d4e1be into mozilla:master Jan 4, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 4, 2025

Thank you! The number of strange things PDF generators do sometimes never fails to amaze me, but this is a big improvement in rendering time.

@Snuffleupagus Snuffleupagus deleted the issue-19281 branch January 4, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: It takes 1 minute, 20 seconds to render page that other viewers render in about 1 second.
3 participants