Make MessageHandler.prototype.send able to handle Errors properly
#19255
+21
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
Currently the "DocException" message requires manual handling of `Error`s on both the main- and worker-threads, which leads to some code duplication. Note that the `MessageHandler` implementation already deals with `Error`s when its `sendWithPromise` respectively `sendWithStream` methods are used, and it's easy enough to extend this to also apply to the `send` method. Finally, changes the `wrapReason` helper function to use a slightly shorter parameter name and removes unused entries from the `CallbackKind`/`StreamKind` enumerations.
Snuffleupagus
force-pushed
the
MessageHandler-send-Error
branch
from
8d773a9 to
238000e
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5fb22b94cffe17b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cf3683608996c88/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5fb22b94cffe17b/output.txt Total script time: 28.05 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cf3683608996c88/output.txt Total script time: 52.40 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "DocException" message requires manual handling of
Errors on both the main- and worker-threads, which leads to some code duplication.Note that the
MessageHandlerimplementation already deals withErrors when itssendWithPromiserespectivelysendWithStreammethods are used, and it's easy enough to extend this to also apply to thesendmethod.Finally, changes the
wrapReasonhelper function to use a slightly shorter parameter name and removes unused entries from theCallbackKind/StreamKindenumerations.