-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Avoid to focus an existing editor when enabling the layer #19215
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e405292ff66ba31/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d3aa05cbbfbe31e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e405292ff66ba31/output.txt Total script time: 11.20 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d3aa05cbbfbe31e/output.txt Total script time: 24.61 mins
|
Unfortunately, the puppeteer update brought some Chrome-only new more-or-less intermittent issues... :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, assuming that you're sure that the test failures are unrelated to this patch; thank you.
I thought it was Chrome-only because only CDP was appearing in the backtraces, but in fact the two tests about existing annotations are just failing. I don't why we didn't get an error from the test in Firefox or maybe because the timeout exception for Chrome avoided the one for Firefox. |
f3dea83
to
d61b882
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4893139d5464f32/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/df3597f57c039e9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4893139d5464f32/output.txt Total script time: 10.75 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/df3597f57c039e9/output.txt Total script time: 23.09 mins
|
@Snuffleupagus I made few changes, are you still ok ? |
It fixes #18911.