Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Avoid to focus an existing editor when enabling the layer #19215

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #18911.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e405292ff66ba31/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d3aa05cbbfbe31e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e405292ff66ba31/output.txt

Total script time: 11.20 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d3aa05cbbfbe31e/output.txt

Total script time: 24.61 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

Unfortunately, the puppeteer update brought some Chrome-only new more-or-less intermittent issues... :(

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, assuming that you're sure that the test failures are unrelated to this patch; thank you.

test/integration/highlight_editor_spec.mjs Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

r=me, assuming that you're sure that the test failures are unrelated to this patch; thank you.

I thought it was Chrome-only because only CDP was appearing in the backtraces, but in fact the two tests about existing annotations are just failing. I don't why we didn't get an error from the test in Firefox or maybe because the timeout exception for Chrome avoided the one for Firefox.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4893139d5464f32/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/df3597f57c039e9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/4893139d5464f32/output.txt

Total script time: 10.75 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/df3597f57c039e9/output.txt

Total script time: 23.09 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

@Snuffleupagus I made few changes, are you still ok ?

@calixteman calixteman merged commit a9c5bb2 into mozilla:master Dec 11, 2024
9 checks passed
@calixteman calixteman deleted the issue18911 branch December 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants