Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the canvas is always the first child of its wrapper #19204

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

calixteman
Copy link
Contributor

While drawing, in zooming fast enough, it's possible, intermittently, to have the canvas after the svg which makes the svg invisible.
So this patch makes sure to have the canvas at the right position.

While drawing, in zooming fast enough, it's possible, intermittently, to have the canvas
after the svg which makes the svg invisible.
So this patch makes sure to have the canvas at the right position.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fd2a2c230e44f8e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d77d5c374b7c8f5/output.txt

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Dec 9, 2024

it's possible, intermittently, to have the canvas after the svg which makes the svg invisible.

Sorry, but what SVG is this referring to since I don't believe that the canvasWrapper has any SVG elements?

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d77d5c374b7c8f5/output.txt

Total script time: 9.49 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/fd2a2c230e44f8e/output.txt

Total script time: 24.08 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

it's possible, intermittently, to have the canvas after the svg which makes the svg invisible.

Sorry, but what SVG is this referring to since I don't believe that the canvasWrapper has any SVG elements?

The drawings (highlights and inks) are under the canvasWrapper:
image
The goal of having highlights there was to make sure the blend operation was applied with the canvas as the backdrop.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit f9ae9b0 into mozilla:master Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants