-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to a standard font if a font-file entry doesn't contain a Stream (issue 18941) #18942
Conversation
…ream (issue 18941) The PDF document is clearly corrupt, since it has /FontFile2 entries that are Dictionaries which obviously isn't correct. While there's obviously no guarantee that things will look perfect this way, actually rendering the text at all should be an improvement in general.
d73f4f7
to
e5448b5
Compare
This improves the fixes for e.g. issue 9462 and 18941 slightly and allows better fallback behaviour for non-standard fonts.
e5448b5
to
236c8d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d525400be2b4cec/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1bbe610edadc8fd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d525400be2b4cec/output.txt Total script time: 32.64 mins
Image differences available at: http://54.241.84.105:8877/d525400be2b4cec/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1bbe610edadc8fd/output.txt Total script time: 51.46 mins
Image differences available at: http://54.193.163.58:8877/1bbe610edadc8fd/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/87a91e3d0d05f79/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ef2f8c89efb5ed6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/87a91e3d0d05f79/output.txt Total script time: 20.90 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ef2f8c89efb5ed6/output.txt Total script time: 29.04 mins
|
The PDF document is clearly corrupt, since it has /FontFile2 entries that are Dictionaries which obviously isn't correct.
While there's obviously no guarantee that things will look perfect this way, actually rendering the text at all should be an improvement in general.