[Editor] Move setting window.uiManager back to the test code
#18623
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bdf344314db897a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7c161d86ec8da5a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bdf344314db897a/output.txt Total script time: 8.60 mins
|
In PR mozilla#18574 setting `window.uiManager` was moved into the `src` folder to avoid intermittent integration test failures because at the time we lacked a way to register event listeners early (before PDF.js loads). However, in PR mozilla#18617 this functionality got introduced, so we can now use the new way of setting up the event bus in the tests to move this back to the `test` folder again and to reduce the amount of test-only code in the main codebase as discussed in PR mozilla#18574. Partially reverts e037c57.
timvandermeij
force-pushed
the
uimanager-test
branch
from
1dd6fd3 to
db06011
Compare
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7c161d86ec8da5a/output.txt Total script time: 20.06 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6df492a11d5e785/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5919e602ae30dd2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6df492a11d5e785/output.txt Total script time: 8.66 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5919e602ae30dd2/output.txt Total script time: 18.24 mins
|
In PR #18574 setting
window.uiManagerwas moved into thesrcfolder to avoid intermittent integration test failures because at the time we lacked a way to register event listeners early (before PDF.js loads). However, in PR #18617 this functionality got introduced, so we can now use the new way of setting up the event bus in the tests to move this back to thetestfolder again and to reduce the amount of test-only code in the main codebase as discussed in PR #18574.Partially reverts e037c57.