-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the "switchannotationeditorparams" event in the editor-code (issue 18196) #18605
Conversation
This shortens the code ever so slightly, which cannot hurt.
…ssue 18196) The problem seems to be caused by the browser trying to "restore" editing input-elements, in the various toolbars, to their previous values when the tab is re-opened. Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5f5324cb8732ce6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5f5324cb8732ce6/output.txt Total script time: 1.03 mins Published |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d39133205183851/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dcc1a50fe580c11/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d39133205183851/output.txt Total script time: 8.54 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dcc1a50fe580c11/output.txt Total script time: 18.26 mins
|
I can confirm that the issue no longer happens. Thank you for fixing this! |
The problem seems to be caused by the browser trying to "restore" editor input-elements, in the various toolbars, to their previous values when the tab is re-opened.
Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.