Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add the telemetry for the new alt text (bug 1912500) #18589

Merged
merged 1 commit into from
Aug 10, 2024
Merged

[Editor] Add the telemetry for the new alt text (bug 1912500) #18589

merged 1 commit into from
Aug 10, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman force-pushed the new_alt_text_telemetry branch from 4b1afc4 to 5934eef Compare August 9, 2024 17:37
Snuffleupagus
Snuffleupagus reviewed Aug 9, 2024
View reviewed changes
web/pdf_viewer.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the new_alt_text_telemetry branch from 5934eef to cb011d6 Compare August 9, 2024 18:01
Snuffleupagus
Snuffleupagus approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments; thank you!

src/display/editor/alt_text.js Outdated Show resolved Hide resolved
src/display/editor/stamp.js Outdated Show resolved Hide resolved
web/annotation_editor_params.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
web/toolbar.js Outdated Show resolved Hide resolved
web/toolbar.js Outdated Show resolved Hide resolved
web/toolbar.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the new_alt_text_telemetry branch from cb011d6 to 8c3731a Compare August 10, 2024 13:26
@calixteman calixteman force-pushed the new_alt_text_telemetry branch from 8c3731a to bf0b8c1 Compare August 10, 2024 13:51
@calixteman calixteman closed this Aug 10, 2024
@calixteman calixteman force-pushed the new_alt_text_telemetry branch from bf0b8c1 to 4367fc1 Compare August 10, 2024 16:16
@timvandermeij timvandermeij removed their request for review August 10, 2024 16:17
@calixteman
Copy link
Contributor Author

Strange I didn't closed this PR and I can't reopen it (I wanted to run the new test before merging it).

@calixteman
Copy link
Contributor Author

...

@timvandermeij
Copy link
Contributor

timvandermeij commented Aug 10, 2024 •
edited
Loading

It looks like something went wrong with the Git push that caused the branch to have no new commits compared to master. If that happens, I believe GitHub auto-closes the PR since the PR has no contents anymore. Hovering over the "Reopen and comment" button below seems to confirm that: "There are no new commits on the calixteman:new_alt_text_telemetry branch".

@calixteman
Copy link
Contributor Author

In playing with git reflog, I think I managed to get the patch...

@calixteman calixteman reopened this Aug 10, 2024
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1883723ce15db12/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/48501c614e8faf9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/48501c614e8faf9/output.txt

Total script time: 8.56 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1883723ce15db12/output.txt

Total script time: 18.64 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit e44e4db into mozilla:master Aug 10, 2024
15 checks passed
@calixteman calixteman deleted the new_alt_text_telemetry branch August 10, 2024 16:49
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @timvandermeij @moz-tools-bot @Snuffleupagus