-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all event listeners into Toolbar.prototype.#bindListeners
#18523
Move all event listeners into Toolbar.prototype.#bindListeners
#18523
Conversation
Over time a couple of event listeners have been placed in the constructor, despite there being an existing helper method for that purpose. To improve the code organization, let's move these to the intended method instead.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/23c9934ec7b9fc5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6934e3bc6905d56/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/23c9934ec7b9fc5/output.txt Total script time: 8.47 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6934e3bc6905d56/output.txt Total script time: 17.73 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c8abaa1310fc0d7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c8abaa1310fc0d7/output.txt Total script time: 1.05 mins Published |
Thanks! |
Over time a couple of event listeners have been placed in the constructor, despite there being an existing helper method for that purpose. To improve the code organization, let's move these to the intended method instead.