Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "must check that charLimit is correctly set" scripting integration test #18399

Merged
merged 1 commit into from
Jul 5, 2024
+14 −28
Merged

Fix the "must check that charLimit is correctly set" scripting integration test #18399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 14 additions & 28 deletions test/integration/scripting_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,49 +1535,35 @@ describe("Interaction", () => {

it("must check that charLimit is correctly set", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
pages.map(async ([, page]) => {
await page.waitForFunction(
"window.PDFViewerApplication.scriptingReady === true"
);

await clearInput(page, getSelector("7R"));
timvandermeij marked this conversation as resolved.
Show resolved Hide resolved
// By default the charLimit is 0 which means that the input
// length is unlimited.
await page.type(getSelector("7R"), "abcdefghijklmnopq", {
delay: 10,
});

let value = await page.$eval(getSelector("7R"), el => el.value);
expect(value)
.withContext(`In ${browserName}`)
.toEqual("abcdefghijklmnopq");

// charLimit is set to 1
await page.click(getSelector("9R"));

// The default charLimit is 0, which indicates unlimited text length.
await page.type(getSelector("7R"), "abcdefghij", { delay: 10 });
await page.waitForFunction(
`document.querySelector('${getSelector(
"7R"
)}').value !== "abcdefgh"`
`${getQuerySelector("7R")}.value === "abcdefghij"`
);

value = await page.$eval(getSelector("7R"), el => el.value);
expect(value).withContext(`In ${browserName}`).toEqual("a");
// Increase the charLimit to 1 (this truncates the existing text).
await page.click(getSelector("9R"));
await waitForSandboxTrip(page);
await page.waitForFunction(`${getQuerySelector("7R")}.value === "a"`);

await clearInput(page, getSelector("7R"));
await page.type(getSelector("7R"), "xyz", { delay: 10 });
await page.waitForFunction(`${getQuerySelector("7R")}.value === "x"`);

value = await page.$eval(getSelector("7R"), el => el.value);
expect(value).withContext(`In ${browserName}`).toEqual("x");

// charLimit is set to 2
// Increase the charLimit to 2.
await page.click(getSelector("9R"));
await waitForSandboxTrip(page);

await clearInput(page, getSelector("7R"));
await page.type(getSelector("7R"), "xyz", { delay: 10 });

value = await page.$eval(getSelector("7R"), el => el.value);
expect(value).withContext(`In ${browserName}`).toEqual("xy");
await page.waitForFunction(
`${getQuerySelector("7R")}.value === "xy"`
);
})
);
});
Expand Down