Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the intermittent failures with PageOpen/PageClose test #17205

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix the intermittent failures with PageOpen/PageClose test #17205

merged 1 commit into from
Oct 29, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a6469f60b058986/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/baf431b0bfec5d7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a6469f60b058986/output.txt

Total script time: 5.76 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/baf431b0bfec5d7/output.txt

Total script time: 16.11 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij reviewed Oct 29, 2023
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach in this PR looks a lot easier than what we had. It does seem to fail the "must compute sum of fields" on both Linux and Windows, but it could also be that the fix here highlights an issue with that particular test, or we need to await something else here. In any case, I think this patch is going in the right direction.

test/integration/test_utils.mjs Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0c2c014179b7e41/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/18cca61f87c6a1a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0c2c014179b7e41/output.txt

Total script time: 5.31 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if this test doesn't fail anymore after e.g. two more runs; thank you for fixing and simplifying this!

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/18cca61f87c6a1a/output.txt

Total script time: 18.01 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6cf2addcb723376/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/49deed1416f36d3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/49deed1416f36d3/output.txt

Total script time: 5.31 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6cf2addcb723376/output.txt

Total script time: 17.45 mins

  • Integration Tests: Passed

@calixteman calixteman marked this pull request as ready for review October 29, 2023 20:05
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0256fc42e3f430a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d7a737ca0b13256/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0256fc42e3f430a/output.txt

Total script time: 5.30 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d7a737ca0b13256/output.txt

Total script time: 17.06 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 1ab0f8a into mozilla:master Oct 29, 2023
3 checks passed
@calixteman calixteman deleted the issue17200 branch October 29, 2023 22:23
@Snuffleupagus Snuffleupagus linked an issue Oct 30, 2023 that may be closed by this pull request
Fix integration test "Interaction in doc_actions.pdf for page actions must execute PageOpen and PageClose actions" #17200
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
3 participants
@calixteman @moz-tools-bot @timvandermeij