Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause translation when appending the xfaLayer to the page #17177

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Pause translation when appending the xfaLayer to the page #17177

merged 1 commit into from
Oct 25, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Copy link
Collaborator Author

To not break printing, the following line is purposely kept:

pdf.js/web/xfa_layer_builder.js

Line 75 in b31e77d

this.pageDiv.append(div);

/botio-linux preview

@mozilla mozilla deleted a comment from moz-tools-bot Oct 25, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 25, 2023
@Snuffleupagus Snuffleupagus marked this pull request as draft October 25, 2023 18:18
@Snuffleupagus
Copy link
Collaborator Author

There was a couple of timing-related issues to consider here, but I think that this should work now. (A code comment was added to hopefully help explain things, and to avoid future issues.)

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fd8e9a914682eac/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fd8e9a914682eac/output.txt

Total script time: 1.46 mins

Published

@Snuffleupagus Snuffleupagus marked this pull request as ready for review October 25, 2023 18:38
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/52c1a76f50cf8f8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/188a36af01f5670/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/188a36af01f5670/output.txt

Total script time: 5.83 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/52c1a76f50cf8f8/output.txt

Total script time: 15.02 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/aa3b8fd3d567f57/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c7ed7d7b148581f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/aa3b8fd3d567f57/output.txt

Total script time: 5.52 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c7ed7d7b148581f/output.txt

Total script time: 14.39 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit fbfacf8 into mozilla:master Oct 25, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the xfaLayer-pause-l10n branch October 26, 2023 08:27
@Snuffleupagus Snuffleupagus mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
form-xfa l10n Localization viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman