Merge pull request #18643 from Snuffleupagus/l10n-translateOnce

Introduce a `L10n`-method to translate an element once, and use that in `PDFLayerViewer`
mozilla · Aug 23, 2024 · f11baea · f11baea
2 parents f025cec + fabbe54
commit f11baea
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/web/l10n.js b/web/l10n.js
@@ -80,6 +80,15 @@ class L10n {
     }
   }
 
+  /** @inheritdoc */
+  async translateOnce(element) {
+    try {
+      await this.#l10n.translateElements([element]);
+    } catch (ex) {
+      console.error(`translateOnce: "${ex}".`);
+    }
+  }
+
   /** @inheritdoc */
   async destroy() {
     for (const element of this.#elements) {

diff --git a/web/pdf_layer_viewer.js b/web/pdf_layer_viewer.js
@@ -93,13 +93,16 @@ class PDFLayerViewer extends BaseTreeViewer {
   /**
    * @private
    */
-  async _setNestedName(element, { name = null }) {
+  _setNestedName(element, { name = null }) {
     if (typeof name === "string") {
       element.textContent = this._normalizeTextContent(name);
       return;
     }
-    element.textContent = await this._l10n.get("pdfjs-additional-layers");
+    element.setAttribute("data-l10n-id", "pdfjs-additional-layers");
     element.style.fontStyle = "italic";
+    // Trigger translation manually, since translation is paused when
+    // the final layer-tree is appended to the DOM.
+    this._l10n.translateOnce(element);
   }
 
   /**