Skip to content

Commit

Permalink
Toggle the visibility of the outlineOptionsContainer, in the sideba…
Browse files Browse the repository at this point in the history
…r, using only CSS

Now that `:has()` is available we no longer need to use JavaScript to toggle the visibility of this DOM element.
  • Loading branch information
Snuffleupagus committed Dec 19, 2023
1 parent 52ffd26 commit 8246429
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 13 deletions.
9 changes: 0 additions & 9 deletions web/pdf_sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ const UI_NOTIFICATION_CLASS = "pdfSidebarNotification";
* the attachments are placed.
* @property {HTMLDivElement} layersView - The container in which
* the layers are placed.
* @property {HTMLDivElement} outlineOptionsContainer - The container in which
* the outline view-specific option button(s) are placed.
* @property {HTMLButtonElement} currentOutlineItemButton - The button used to
* find the current outline item.
*/
Expand Down Expand Up @@ -107,7 +105,6 @@ class PDFSidebar {
this.attachmentsView = elements.attachmentsView;
this.layersView = elements.layersView;

this._outlineOptionsContainer = elements.outlineOptionsContainer;
this._currentOutlineItemButton = elements.currentOutlineItemButton;

this.eventBus = eventBus;
Expand Down Expand Up @@ -227,12 +224,6 @@ class PDFSidebar {
this.layersView
);

// Finally, update view-specific CSS classes.
this._outlineOptionsContainer.classList.toggle(
"hidden",
view !== SidebarView.OUTLINE
);

if (forceOpen && !this.isOpen) {
this.open();
return; // Opening will trigger rendering and dispatch the event.
Expand Down
8 changes: 8 additions & 0 deletions web/viewer.css
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,14 @@ a:focus > .thumbnail > .thumbnailImage,
color: var(--treeitem-hover-color);
}

#outlineOptionsContainer {
display: none;

#sidebarContainer:has(#outlineView:not(.hidden)) & {
display: inherit;
}
}

.dialogButton {
width: auto;
margin: 3px 4px 2px !important;
Expand Down
2 changes: 1 addition & 1 deletion web/viewer.html
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
</div>

<div id="toolbarSidebarRight">
<div id="outlineOptionsContainer" class="hidden">
<div id="outlineOptionsContainer">
<div class="verticalToolbarSeparator"></div>

<button id="currentOutlineItem" class="toolbarButton" disabled="disabled" title="Find Current Outline Item" tabindex="6" data-l10n-id="pdfjs-current-outline-item-button">
Expand Down
3 changes: 0 additions & 3 deletions web/viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ function getViewerConfiguration() {
attachmentsView: document.getElementById("attachmentsView"),
layersView: document.getElementById("layersView"),
// View-specific options
outlineOptionsContainer: document.getElementById(
"outlineOptionsContainer"
),
currentOutlineItemButton: document.getElementById("currentOutlineItem"),
},
findBar: {
Expand Down

0 comments on commit 8246429

Please sign in to comment.