Merge pull request #18613 from calixteman/enable_tests

Enable disabled integration tests for Firefox
mozilla · Aug 15, 2024 · 73bae55 · 73bae55
2 parents b60261e + 75e5236
commit 73bae55
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/test/integration/stamp_editor_spec.mjs b/test/integration/stamp_editor_spec.mjs
@@ -106,11 +106,6 @@ describe("Stamp Editor", () => {
     it("must load a PNG which is bigger than a page", async () => {
       await Promise.all(
         pages.map(async ([browserName, page]) => {
-          if (browserName === "firefox") {
-            // Disabled in Firefox, because of https://bugzilla.mozilla.org/1553847.
-            return;
-          }
-
           await switchToStamp(page);
           await page.click("#editorStampAddImage");
 
@@ -138,11 +133,6 @@ describe("Stamp Editor", () => {
     it("must load a SVG", async () => {
       await Promise.all(
         pages.map(async ([browserName, page]) => {
-          if (browserName === "firefox") {
-            // Disabled in Firefox, because of https://bugzilla.mozilla.org/1553847.
-            return;
-          }
-
           await page.click("#editorStampAddImage");
           const input = await page.$("#stampEditorFileInput");
           await input.uploadFile(
@@ -183,11 +173,6 @@ describe("Stamp Editor", () => {
     it("must check that an added image stay within the page", async () => {
       await Promise.all(
         pages.map(async ([browserName, page]) => {
-          if (browserName === "firefox") {
-            // Disabled in Firefox, because of https://bugzilla.mozilla.org/1553847.
-            return;
-          }
-
           await switchToStamp(page);
           const names = ["bottomLeft", "bottomRight", "topRight", "topLeft"];
 

diff --git a/test/integration/viewer_spec.mjs b/test/integration/viewer_spec.mjs
@@ -115,12 +115,6 @@ describe("PDF viewer", () => {
     it("must check that we can zoom with the mouse wheel and pressed control key", async () => {
       await Promise.all(
         pages.map(async ([browserName, page]) => {
-          if (browserName === "firefox") {
-            // Skip this test for Firefox, as it's not working correctly.
-            // See https://github.com/puppeteer/puppeteer/issues/12093.
-            // TODO: Remove this check once the issue is resolved.
-            return;
-          }
           await page.keyboard.down("Control");
           let zoom = 10;
           const zoomGetter = () =>