Skip to content

Commit

Permalink
Improve performance of optional content parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
calixteman committed Oct 25, 2023
1 parent f27f2bb commit 353d968
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/core/catalog.js
Original file line number Diff line number Diff line change
Expand Up @@ -438,13 +438,13 @@ class Catalog {
return shadow(this, "optionalContentConfig", null);
}
const groups = [];
const groupRefs = [];
const groupRefs = new RefSet();
// Ensure all the optional content groups are valid.
for (const groupRef of groupsData) {
if (!(groupRef instanceof Ref)) {
if (!(groupRef instanceof Ref) || groupRefs.has(groupRef)) {
continue;
}
groupRefs.push(groupRef);
groupRefs.put(groupRef);
const group = this.xref.fetchIfRef(groupRef);
groups.push({
id: groupRef.toString(),
Expand Down Expand Up @@ -477,7 +477,7 @@ class Catalog {
if (!(value instanceof Ref)) {
continue;
}
if (contentGroupRefs.includes(value)) {
if (contentGroupRefs.has(value)) {
onParsed.push(value.toString());
}
}
Expand All @@ -492,7 +492,7 @@ class Catalog {
const order = [];

for (const value of refs) {
if (value instanceof Ref && contentGroupRefs.includes(value)) {
if (value instanceof Ref && contentGroupRefs.has(value)) {
parsedOrderRefs.put(value); // Handle "hidden" groups, see below.

order.push(value.toString());
Expand Down

0 comments on commit 353d968

Please sign in to comment.