Merge pull request #18968 from calixteman/bug1903588

[Editor] Split the long words when showing the alt-text tooltip (bug 1903588)
mozilla · Oct 28, 2024 · 07a1d30 · 07a1d30
2 parents 2bee3af + 8fbb9e2
commit 07a1d30
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/test/integration/stamp_editor_spec.mjs b/test/integration/stamp_editor_spec.mjs
@@ -337,13 +337,14 @@ describe("Stamp Editor", () => {
         expect(tooltipText).toEqual("Hello World");
 
         // Now we change the alt-text and check that the tooltip is updated.
+        const longString = "a".repeat(512);
         await page.click(buttonSelector);
         await page.waitForSelector("#altTextDialog", { visible: true });
         await page.evaluate(sel => {
           document.querySelector(`${sel}`).value = "";
         }, textareaSelector);
         await page.click(textareaSelector);
-        await page.type(textareaSelector, "Dlrow Olleh");
+        await page.type(textareaSelector, longString);
         await page.click(saveButtonSelector);
         await page.waitForSelector(`${buttonSelector}.done`);
         await page.hover(buttonSelector);
@@ -352,7 +353,14 @@ describe("Stamp Editor", () => {
           sel => document.querySelector(`${sel}`).innerText,
           tooltipSelector
         );
-        expect(tooltipText).toEqual("Dlrow Olleh");
+        expect(tooltipText).toEqual(longString);
+        const dims = await page.evaluate(sel => {
+          const { width, height } = document
+            .querySelector(`${sel}`)
+            .getBoundingClientRect();
+          return { width, height };
+        }, tooltipSelector);
+        expect(dims.width / dims.height).toBeLessThan(2);
 
         // Now we just check that cancel didn't change anything.
         await page.click(buttonSelector);
@@ -371,8 +379,8 @@ describe("Stamp Editor", () => {
           sel => document.querySelector(`${sel}`).innerText,
           tooltipSelector
         );
-        // The tooltip should still be "Dlrow Olleh".
-        expect(tooltipText).toEqual("Dlrow Olleh");
+        // The tooltip should still be longString.
+        expect(tooltipText).toEqual(longString);
 
         // Now we switch to decorative.
         await page.click(buttonSelector);
@@ -402,7 +410,7 @@ describe("Stamp Editor", () => {
           sel => document.querySelector(`${sel}`).innerText,
           tooltipSelector
         );
-        expect(tooltipText).toEqual("Dlrow Olleh");
+        expect(tooltipText).toEqual(longString);
 
         // Now we remove the alt-text and check that the tooltip is removed.
         await page.click(buttonSelector);

diff --git a/web/annotation_editor_layer_builder.css b/web/annotation_editor_layer_builder.css
@@ -451,6 +451,7 @@
 
         .tooltip {
           display: none;
+          word-wrap: anywhere;
 
           &.show {
             --alt-text-tooltip-bg: #f0f0f4;