Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin nightly #2370

Merged
merged 2 commits into from
Jan 16, 2025
Merged

ci: pin nightly #2370

merged 2 commits into from
Jan 16, 2025

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Jan 16, 2025

Fixes #2369.

Once this is merged, I can tackle #2365.

Once #2365 is fixed, I can try fixing the sanitizer failures on Ubuntu 22.04.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (6b87603) to head (7b55c01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2370   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         114      114           
  Lines       36856    36856           
  Branches    36856    36856           
=======================================
  Hits        35123    35123           
  Misses       1727     1727           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxinden mxinden force-pushed the pin-nightly-windows branch from d3de8f8 to 921be34 Compare January 16, 2025 13:39
@mxinden mxinden marked this pull request as ready for review January 16, 2025 13:56
Copy link
Collaborator

@larseggert larseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but CI seems unhappy.

Copy link

github-actions bot commented Jan 16, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 7f8136e.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden
Copy link
Collaborator Author

mxinden commented Jan 16, 2025

The sanitize failures should be unrelated. I hope they are fixed once we merge #2364.

The netbsd failure is unrelated, i.e. due to a wrong NSS version.

As far as I can tell, the QNS failures are also unrelated.

Anything else I am missing @larseggert?

@mxinden mxinden enabled auto-merge January 16, 2025 14:37
@mxinden mxinden added this pull request to the merge queue Jan 16, 2025
Merged via the queue into mozilla:main with commit e18658d Jan 16, 2025
62 of 70 checks passed
@mxinden mxinden deleted the pin-nightly-windows branch January 16, 2025 16:17
mxinden added a commit to mxinden/neqo that referenced this pull request Jan 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Windows Nightly fails with (exit code: 0xc000001d, STATUS_ILLEGAL_INSTRUCTION)
2 participants