-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin nightly #2370
ci: pin nightly #2370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 114 114
Lines 36856 36856
Branches 36856 36856
=======================================
Hits 35123 35123
Misses 1727 1727
Partials 6 6 ☔ View full report in Codecov by Sentry. |
d3de8f8
to
921be34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but CI seems unhappy.
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 7f8136e. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
The sanitize failures should be unrelated. I hope they are fixed once we merge #2364. The netbsd failure is unrelated, i.e. due to a wrong NSS version. As far as I can tell, the QNS failures are also unrelated. Anything else I am missing @larseggert? |
This reverts commit e18658d.
Fixes #2369.
Once this is merged, I can tackle #2365.
Once #2365 is fixed, I can try fixing the sanitizer failures on Ubuntu 22.04.