chore: Address new nightly clippy warnings #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36357 36357
=======================================
Hits 34669 34669
Misses 1688 1688 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 12fc1aa. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.601 ns 98.943 ns 99.295 ns]
change: [-0.0325% +0.4451% +0.9626%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.39 ns 116.68 ns 116.98 ns]
change: [-0.4398% +0.1982% +0.8839%] (p = 0.61 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.36 ns 116.91 ns 117.52 ns]
change: [-0.5140% +0.1867% +0.8869%] (p = 0.62 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.372 ns 101.34 ns 110.32 ns]
change: [-1.3662% +2.2373% +8.4319%] (p = 0.57 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.31 ms 111.45 ms 111.70 ms]
change: [-0.4420% -0.1837% +0.0842%] (p = 0.18 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.783 ms 27.936 ms 29.095 ms]
change: [-2.2879% +3.2360% +9.0768%] (p = 0.26 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.327 ms 36.018 ms 37.741 ms]
change: [-8.1001% -1.4117% +5.6950%] (p = 0.69 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.085 ms 25.836 ms 26.595 ms]
change: [-3.5248% +0.4206% +4.7976%] (p = 0.84 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [43.043 ms 45.148 ms 47.276 ms]
change: [+1.3757% +8.5456% +16.169%] (p = 0.02 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.59 ms 113.93 ms 114.27 ms]
thrpt: [875.12 MiB/s 877.73 MiB/s 880.39 MiB/s]
change:
time: [-0.4083% +0.1287% +0.6503%] (p = 0.64 > 0.05)
thrpt: [-0.6461% -0.1286% +0.4100%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [308.53 ms 312.55 ms 316.58 ms]
thrpt: [31.588 Kelem/s 31.995 Kelem/s 32.411 Kelem/s]
change:
time: [-2.2887% -0.5103% +1.2162%] (p = 0.57 > 0.05)
thrpt: [-1.2016% +0.5129% +2.3423%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [34.004 ms 34.180 ms 34.364 ms]
thrpt: [29.100 elem/s 29.257 elem/s 29.408 elem/s]
change:
time: [-0.6494% +0.0355% +0.8264%] (p = 0.92 > 0.05)
thrpt: [-0.8196% -0.0355% +0.6537%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.