Skip to content

Commit

Permalink
fix: forward bench feature to test-fixtures crate (#2201)
Browse files Browse the repository at this point in the history
Previously `neqo-bin`, `neqo-transport` and `test-fixtures` would each define a
`bench` feature. But enabling e.g. `bench` in `neqo-transport` would not enable
`bench` in `test-fixtures`. Thus a benchmark in e.g. `neqo-transport` with
`--features bench` would still be serializing qlog traces.

This commit makes `neqo-bin` and `neqo-transport` forward their `bench` feature
to `test-fixtures`.
  • Loading branch information
mxinden authored Oct 26, 2024
1 parent 67d5e7f commit 05b4af9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion neqo-bin/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ criterion = { version = "0.5", default-features = false, features = ["async_toki
tokio = { version = "1", default-features = false, features = ["sync"] }

[features]
bench = []
bench = ["neqo-transport/bench"]

[lib]
# See https://github.com/bheisler/criterion.rs/blob/master/book/src/faq.md#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
Expand Down
2 changes: 1 addition & 1 deletion neqo-transport/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ criterion = { version = "0.5", default-features = false }
test-fixture = { path = "../test-fixture" }

[features]
bench = []
bench = ["test-fixture/bench"]
build-fuzzing-corpus = [
"neqo-common/build-fuzzing-corpus",
"neqo-crypto/disable-encryption",
Expand Down

0 comments on commit 05b4af9

Please sign in to comment.