Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1886702 - Fix util.load_yaml_or_json failures when loading json files #679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serge-sans-paille
Copy link
Contributor

Line number information are not available through the json API, but providing null line number is enough to make it compatible with other parts.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@serge-sans-paille serge-sans-paille force-pushed the feature/improve-json-loader branch 2 times, most recently from 7c50793 to 754c978 Compare March 26, 2024 09:59
@badboy badboy changed the title Fix util.load_yaml_or_json failures when loading json files Bug 1886702 - Fix util.load_yaml_or_json failures when loading json files Mar 26, 2024
@serge-sans-paille serge-sans-paille force-pushed the feature/improve-json-loader branch 2 times, most recently from 10c0155 to d91d0f4 Compare March 26, 2024 10:11
Line number information are not available through the json API, but
providing null line number is enough to make it compatible with other
parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant