This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
feat(avatars): enable default avatar #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rfk
approved these changes
Feb 25, 2018
docs/API.md
Outdated
|
|
||
| #### Response | ||
|
|
||
| > Note: we no longer support Gravatar uploading, but there are entries in the database |
There was a problem hiding this comment.
Are there? Side note, but I wonder if we should somehow purge them.
There was a problem hiding this comment.
Mistake, we actually used to process them, I guess the docs always had an incorrect url
| @@ -20,6 +28,26 @@ exports.create = function() { | |||
| port: config.server.port + 1 | |||
| }); | |||
|
|
|||
| server.route({ | |||
| method: 'GET', | |||
| path: '/a/' + DEFAULT_AVATAR_ID + '{type?}', | |||
There was a problem hiding this comment.
👍 I like this way of just making it all a bit simpler for dev
vladikoff
added a commit
that referenced
this pull request
Feb 28, 2018
vladikoff
added a commit
that referenced
this pull request
Feb 28, 2018
This reverts commit 01b0e41.
vladikoff
added a commit
that referenced
this pull request
Feb 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295