This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(mysql): Set strict mode on all new db migrations. #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
We've stored enforcing strict-mode on all connections to MySQL from the app at runtime. However, stored procedures remember the sql_mode that was in effect at the time they were created, and we create our stored procedures through an out-of-band connection that doesn't force strict mode. This change adds an explicit "enable strict mode" preamble to new migrations, and re-creates on of the existing stored procedures to make use of it. Once we're confident this will work on OK in practice, we'll need to re-create all stored procedures that might have been created without strict mode.
rfk
force-pushed
the
strict-mode-migrations
branch
from
115176c
to
3c96a63
Compare
|
Going to pick this up for some background hacking in the next train. |
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've stored enforcing strict-mode on all connections to
MySQL from the app at runtime. However, stored procedures
remember the sql_mode that was in effect at the time they
were created, and we create our stored procedures through
an out-of-band connection that doesn't force strict mode.
This change adds an explicit "enable strict mode" preamble
to new migrations, and re-creates on of the existing stored
procedures to make use of it. Once we're confident this will
work on OK in practice, we'll need to re-create all stored
procedures that might have been created without strict mode.
This is a trial-baloon PR to see if it works in CI.