Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of issues listing API endpoint #2376

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

La0
Copy link
Collaborator

@La0 La0 commented Sep 19, 2024

Refs #2270

This is the implementation of my previous findings

  • add index on Revision.head_changeset & Issue.path that are used in the various filters of the endpoint
  • smaller serializer to only load & expose what's needed by the bot
  • aggregate all filters into a dict to make Django ORM smarter and avoid joining on IssueLink multiple times

Using a prod dump on a local server (not tested on heroku), this gives a 25% to 30% speed boots (from ~1s down to 750ms).

Endpoint is still relatively slow, but to go further it would need a larger refactoring to discuss

@La0 La0 self-assigned this Sep 19, 2024
@Archaeopteryx Archaeopteryx merged commit ee40887 into mozilla:master Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants