-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus has enrolments as an array #5509
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 4de104f.
Preview URL 🚀 : https://blurts-server-pr-5509-mgjlpikfea-uk.a.run.app |
Hm I think you're right, here's the sample that the Nimbus team gave us https://gist.github.com/yashikakhurana/f2fec74b0b6182d03adf957ceedd41b3 |
I'd like to land the other PRs first and see what's going on with stage, this was definitely working (with the So I'd like to understand the current state after things are rolled back before we land, I don't doubt that this is a problem though I just want to understand the sequence of what happened. |
Hm maybe there is a problem with the documentation... I did test this and it worked as expected (with V2), I'll re-test before we land this. It might be a bug in Cirrus (or its docs). |
Stage is working now with everything else landed, I flipped the So I think it's OK to land this one, I think we might need to dig into this one some more though. |
@rhelmer That does indicate that we need to fix this, but I'm still not sure that this PR is the right fix. (Or actually, I'm fairly sure it's not.) I still have this open question for Yashika about how to pass the enrollments to Glean, given that Glean only accepts single enrollments. |
i.e. make their names plural where they accept arrays.
Waiting for an update to Glean.js to support arrays in |
This PR I'm not sure about, and it's probably wrong, but: in MNTOR-3812, @rhelmer showed an example with
Enrollments
being an array, whereas our code says that it's a single object.I'm not sure if it actually is, and if it is, I'm not sure why and how we're supposed to handle it - in this PR, I'm just always getting the first element, but that's probably not correct. However, I figured I'd submit this PR to at least have this observation in play somewhere.