Remote Settings: store full changesets instead of just records #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
reviewed
Dec 9, 2024
bendk
reviewed
Dec 9, 2024
leplatrem
force-pushed
the
remote-settings-store-metadata
branch
2 times, most recently
from
cbeee6b to
68c8951
Compare
leplatrem
force-pushed
the
remote-settings-store-metadata
branch
3 times, most recently
from
dca1f28 to
f8ead0e
Compare
11 tasks
leplatrem
force-pushed
the
remote-settings-store-metadata
branch
from
f8ead0e to
89d95d2
Compare
gruberb
approved these changes
Dec 20, 2024
bendk
requested changes
Dec 20, 2024
leplatrem
commented
Dec 20, 2024
bendk
approved these changes
Jan 3, 2025
| @@ -27,7 +27,7 @@ CREATE TABLE IF NOT EXISTS attachments ( | |||
| data BLOB NOT NULL); | |||
| CREATE TABLE IF NOT EXISTS collection_metadata ( | |||
| collection_url TEXT PRIMARY KEY, | |||
| last_modified INTEGER); | |||
| last_modified INTEGER, bucket TEXT, signature TEXT, x5u TEXT); | |||
There was a problem hiding this comment.
Sorry you needed to format it like this to make the migration test work.
Yes! I'll squash the commits and merge 👌 |
leplatrem
force-pushed
the
remote-settings-store-metadata
branch
from
9450391 to
80ea542
Compare
leplatrem
force-pushed
the
remote-settings-store-metadata
branch
from
80ea542 to
caa8fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prepare the work of signature verification, where we want to be able to assess data integrity/authenticity, we need to store collection metadata and timestamps.
Also, this PR fixes an issue where the timestamp was wrong in certain cases (empty collections, tombstones, etc.)
It is an internal change that does not require a CHANGELOG entry.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.