Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust enrollment status telemetry to only send for active experiments (backport #5889) #5954

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 29, 2023

This is an automatic backport of pull request #5889 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to unblock the backport of #5916. Approved for A-S 120.0.2 & Fenix 120.1.0.

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (adbf041) 37.52% compared to head (02b1c6d) 37.51%.

Files Patch % Lines
components/nimbus/src/stateful/nimbus_client.rs 0.00% 8 Missing ⚠️
components/nimbus/src/stateful/dbcache.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-v120    #5954      +/-   ##
================================================
- Coverage         37.52%   37.51%   -0.02%     
================================================
  Files               346      346              
  Lines             32840    32851      +11     
================================================
  Hits              12324    12324              
- Misses            20516    20527      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvandermeulen rvandermeulen merged commit 2e80385 into release-v120 Nov 29, 2023
14 of 15 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release-v120/pr-5889 branch November 29, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants